Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Information
Submitter:	lixd
Repository:	yunna
Branch:
Bugs:
Depends On:
Reviewers
Groups:	review
People:	zjy

Description

云纳接口对接

Testing Done

Issues

15
0
0
All Issues: 15

Description	From	Last Updated
写法不合理，control层应该写什么？	zjy	April 7, 2023, 7:10 a.m.
异常情况逻辑不合理	zjy	April 7, 2023, 7:10 a.m.
重新赋值不合理	zjy	April 7, 2023, 7:10 a.m.
为什么list？为什么不放到common？	zjy	April 7, 2023, 7:10 a.m.
为什么没有事务？	zjy	April 7, 2023, 7:10 a.m.
使用copy进行赋值	zjy	April 7, 2023, 7:10 a.m.
缺少事务	zjy	April 7, 2023, 7:10 a.m.
缺少事务	zjy	April 7, 2023, 7:10 a.m.
没有注解	zjy	April 7, 2023, 7:10 a.m.
三元表达式	zjy	April 7, 2023, 7:10 a.m.
缺少事务	zjy	April 7, 2023, 7:10 a.m.
多余写法	zjy	April 7, 2023, 7:10 a.m.
直接普通for循环	zjy	April 7, 2023, 7:10 a.m.
严重问题异常不抛出	zjy	April 7, 2023, 7:10 a.m.
一样的问题	zjy	April 7, 2023, 7:10 a.m.

Fix it!

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/control/FruitShipPortControl.java (Diff revision 1)

Show all issues

写法不合理，control层应该写什么？

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/control/FruitShipPortControl.java (Diff revision 1)

Show all issues

异常情况逻辑不合理

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/control/FruitShipPortControl.java (Diff revision 1)

Show all issues

重新赋值不合理

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

为什么list？为什么不放到common？

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

为什么没有事务？

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

使用copy进行赋值

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

缺少事务

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

缺少事务

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

没有注解

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/FruitShipPortServiceImpl.java (Diff revision 1)

Show all issues

三元表达式

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/PortServiceImpl.java (Diff revision 1)

Show all issues

缺少事务

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/PortServiceImpl.java (Diff revision 1)

Show all issues

多余写法

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/PortServiceImpl.java (Diff revision 1)

Show all issues

直接普通for循环

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/PortServiceImpl.java (Diff revision 1)

Show all issues

严重问题异常不抛出

svn://47.98.170.39/jinan/trunk/yunna/src/main/java/com/freshport/service/impl/ShipServiceImpl.java (Diff revision 1)

Show all issues

一样的问题

Status: Closed (submitted)

Loading...