Docs
Support

JavaScript is turned off

Review Board requires JavaScript in order to function. Please turn it on in your browser preferences.

Firefox users: if you prefer to turn on JavaScript only for specific sites, we recommend the NoScript extension.

Reviews
Diff

- Download Diff

Information
Submitter:	gubj
Repository:	paycontrol
Branch:
Bugs:
Depends On:
Reviewers
Groups:
People:	zjy

Description

paycontrol-2022061602

Testing Done

Issues

11
0
0
All Issues: 11

Description	From	Last Updated
缺少前置校验	zjy	June 16, 2022, 2:27 a.m.
解析方式不合理	zjy	June 16, 2022, 2:27 a.m.
缺少注释	zjy	June 16, 2022, 2:27 a.m.
不合理的返回值	zjy	June 16, 2022, 2:27 a.m.
方法太长进行抽取	zjy	June 16, 2022, 2:27 a.m.
常量不要写死	zjy	June 16, 2022, 2:27 a.m.
不应写死反射获取	zjy	June 16, 2022, 2:27 a.m.
不要造轮子用Apache的fileutil工具类写	zjy	June 16, 2022, 2:27 a.m.
漏了事务注解	zjy	June 16, 2022, 2:33 a.m.
public使用范围过大	zjy	June 16, 2022, 2:33 a.m.
缺少事务注解	zjy	June 16, 2022, 2:33 a.m.

Fix it!

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/control/ApiControl.java (Diff revision 1)

Show all issues

缺少前置校验

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/control/ApiControl.java (Diff revision 1)

Show all issues

解析方式不合理

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/control/ApiControl.java (Diff revision 1)

Show all issues

缺少注释

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/control/ApiControl.java (Diff revision 1)

Show all issues

不合理的返回值

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/GrabPayServiceImpl.java (Diff revision 1)

Show all issues

方法太长进行抽取

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/RuleServiceIml.java (Diff revision 1)

Show all issues

常量不要写死

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/RuleServiceIml.java (Diff revision 1)

Show all issues

不应写死反射获取

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/RuleServiceIml.java (Diff revision 1)

Show all issues

不要造轮子用Apache的fileutil工具类写

Fix it!

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/GrabPayServiceImpl.java (Diff revision 1)

Show all issues

漏了事务注解

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/GrabPayServiceImpl.java (Diff revision 1)

Show all issues

public使用范围过大

svn://47.98.170.39/jinan/trunk/paycontrol/src/main/java/com/novaone/service/impl/GrabPayServiceImpl.java (Diff revision 1)

Show all issues

缺少事务注解

Status: Discarded

Loading...